Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix error in Proxy set implementation #2369

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix error in Proxy set implementation #2369

wants to merge 2 commits into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 22, 2022

This Pull Request changes the following:

  • Fix error in Proxy set implementation

After this all other failing Proxy tests fail because of us missing the with implementation.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Oct 22, 2022
@raskad raskad added this to the v0.17.0 milestone Oct 22, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,383 93,383 0
Passed 69,102 69,114 +12
Ignored 18,182 18,182 0
Failed 6,099 6,087 -12
Panics 0 0 0
Conformance 74.00% 74.01% +0.01%
Fixed tests (12): 
test/built-ins/Proxy/set/call-parameters.js [strict mode] (previously Failed)
test/built-ins/Proxy/set/call-parameters.js (previously Failed)
test/built-ins/Proxy/set/call-parameters-prototype-dunder-proto.js [strict mode] (previously Failed)
test/built-ins/Proxy/set/call-parameters-prototype-dunder-proto.js (previously Failed)
test/built-ins/Proxy/set/call-parameters-prototype.js [strict mode] (previously Failed)
test/built-ins/Proxy/set/call-parameters-prototype.js (previously Failed)
test/built-ins/Proxy/set/trap-is-undefined-target-is-proxy.js [strict mode] (previously Failed)
test/built-ins/Proxy/set/trap-is-undefined-target-is-proxy.js (previously Failed)
test/built-ins/Proxy/set/call-parameters-prototype-index.js [strict mode] (previously Failed)
test/built-ins/Proxy/set/call-parameters-prototype-index.js (previously Failed)
test/built-ins/Array/prototype/reverse/length-exceeding-integer-limit-with-proxy.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/reverse/length-exceeding-integer-limit-with-proxy.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 22, 2022 •
edited
Loading

Codecov Report

Merging #2369 (05900b7) into main (d4c220a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2369      +/-   ##
==========================================
- Coverage   39.89%   39.88%   -0.01%     
==========================================
  Files         243      243              
  Lines       23289    23293       +4     
==========================================
  Hits         9290     9290              
- Misses      13999    14003       +4
Impacted Files Coverage Δ
boa_engine/src/object/internal_methods/proxy.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Razican
Razican approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!

@Razican
Copy link
Member

Razican commented Oct 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 22, 2022
@raskad @RageKnify
Fix error in Proxy set implementation (#2369)
80017fd 
This Pull Request changes the following:

- Fix error in `Proxy` set implementation

After this all other failing `Proxy` tests fail because of us missing the `with` implementation.

Co-authored-by: RageKnify <RageKnify@gmail.com>
HalidOdat
HalidOdat approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@bors
Copy link

bors bot commented Oct 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix error in Proxy set implementation [Merged by Bors] - Fix error in Proxy set implementation Oct 22, 2022
@bors bors bot closed this Oct 22, 2022
@bors bors bot deleted the proxy-fix branch October 22, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RageKnify RageKnify RageKnify approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@raskad @Razican @HalidOdat @RageKnify