-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix property access of call expression #2273
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
+ Coverage 41.33% 41.35% +0.02%
==========================================
Files 234 234
Lines 22019 22019
==========================================
+ Hits 9101 9107 +6
+ Misses 12918 12912 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Test262 conformance changesVM implementation
Fixed tests (4):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the fix :) Just a suggestion to reduce code repetition and make things more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you for the additional tests and match fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! Thanks! LGTM
bors r+ |
Fix a syntax error when accessing literal-like property names of call expression. e.g.) `fn().true`
Pull request successfully merged into main. Build succeeded: |
Fix a syntax error when accessing literal-like property names of call expression.
e.g.)
fn().true