[Merged by Bors] - Implement Async Generators #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
enhancement
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Codecov Report
@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
- Coverage 41.99% 41.54% -0.46%
==========================================
Files 231 234 +3
Lines 21530 21891 +361
==========================================
+ Hits 9042 9094 +52
- Misses 12488 12797 +309
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
VM implementation
|
Razican
reviewed
Jul 24, 2022
HalidOdat
approved these changes
Jul 26, 2022
bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
Currently async generator class methods are not being parsed correctly. In comparison to the current main branch this only fixes a few tests, but after #2200 is merged, it should be aroud 1000 additional passing tests.
raskad
force-pushed
the
implement-async-generator
branch
from
b3afd4f to
e11d9b0
Compare
Razican
approved these changes
Aug 13, 2022
boa_engine/src/bytecompiler.rs
Outdated
|
|
||
| /// `FunctionCompiler` is used to compile AST functions to bytecode. | ||
| #[derive(Debug, Clone, Copy)] | ||
| pub(crate) struct FunctionCompiler { |
There was a problem hiding this comment.
I would move this struct to a sub-module. 3k lines is already too much in this file, and we also have #1808 that mentions dividing this huge file into smaller parts.
There was a problem hiding this comment.
True. I have moved the bytecompiler to a module folder and created a separate file for the function compiler. I think from here we can do further dividing.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2022
This Pull Request fixes #1560. It changes the following: - Implement `AsyncGeneratorFunction` builtin object. - Implement `AsyncGenerator` builtin object. - Implement async generator execution. - Add some parse errors for async generators. The `AsyncGenerator.prototype.return()` method currently does not work correctly with `finally` blocks, but I think we should merge this first to not increase the complexity of the pr too much.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #1560.
It changes the following:
AsyncGeneratorFunctionbuiltin object.AsyncGeneratorbuiltin object.The
AsyncGenerator.prototype.return()method currently does not work correctly withfinallyblocks, but I think we should merge this first to not increase the complexity of the pr too much.