[Merged by Bors] - Refactor construct and PromiseCapability to preserve JsObject invariants
#2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
execution
jedel1043
force-pushed
the
constructor-improv
branch
from
946e2f1 to
4247ae8
Compare
Test262 conformance changesVM implementation
Fixed tests (311): |
Codecov Report
@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
+ Coverage 43.47% 43.52% +0.05%
==========================================
Files 220 220
Lines 19985 20028 +43
==========================================
+ Hits 8688 8717 +29
- Misses 11297 11311 +14
Continue to review full report at Codecov.
|
Razican
reviewed
Jun 21, 2022
Razican
reviewed
Jun 21, 2022
jedel1043
changed the title
construct always return JsObjectconstruct and Promise to preserve JsObject invariants
jedel1043
changed the title
construct and Promise to preserve JsObject invariants construct and PromiseCapability to preserve JsObject invariants
Razican
approved these changes
Jun 22, 2022
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
…nvariants (#2136) This Pull Request changes the signature of `construct` to always return `JsObject`s, and refactors `PromiseCapability` to store only `JsObject`/`JsFunction`s. This preserves the following invariants specified in the spec: https://tc39.es/ecma262/multipage/ordinary-and-exotic-objects-behaviours.html#sec-ecmascript-function-objects-construct-argumentslist-newtarget > The [[Construct]] internal method of an ECMAScript function object ... returns either a normal completion containing an Object or a throw completion ... https://tc39.es/ecma262/multipage/control-abstraction-objects.html#sec-promisecapability-records Table 82: [PromiseCapability Record](https://tc39.es/ecma262/multipage/control-abstraction-objects.html#sec-promisecapability-records) Fields Field Name | Value | Meaning -- | -- | -- [[Promise]] | an Object | An object that is usable as a promise. [[Resolve]] | a function object | The function that is used to resolve the given promise. [[Reject]] | a function object | The function that is used to reject the given promise. Co-authored-by: Iban Eguia <razican@protonmail.ch>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
construct and PromiseCapability to preserve JsObject invariants construct and PromiseCapability to preserve JsObject invariants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the signature of
constructto always returnJsObjects, and refactorsPromiseCapabilityto store onlyJsObject/JsFunctions. This preserves the following invariants specified in the spec:https://tc39.es/ecma262/multipage/ordinary-and-exotic-objects-behaviours.html#sec-ecmascript-function-objects-construct-argumentslist-newtarget
https://tc39.es/ecma262/multipage/control-abstraction-objects.html#sec-promisecapability-records
Table 82: PromiseCapability Record Fields