[Merged by Bors] - Fix casting negative number to usize in Array.splice
#2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2030 +/- ##
==========================================
- Coverage 44.15% 44.14% -0.01%
==========================================
Files 210 210
Lines 18596 18594 -2
==========================================
- Hits 8211 8209 -2
Misses 10385 10385
Continue to review full report at Codecov.
|
VM implementation
Fixed tests (18): |
raskad
added
bug
raskad
requested review from
jedel1043,
raskad,
HalidOdat,
jasonwilliams,
RageKnify and
Razican
raskad
approved these changes
Apr 14, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
This Pull Request fixes a faulty cast for `Array.splice`. Negative values for delete_count were being directly casted to usize, which was not the intended behavior. This pull request fixes the issue by using a fallible conversion, defaulting to 0 if the conversion fails. It changes the following: - Replace cast in `Array.splice` prototype method with fallible conversion.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Array.spliceArray.splice
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This Pull Request fixes a faulty cast for `Array.splice`. Negative values for delete_count were being directly casted to usize, which was not the intended behavior. This pull request fixes the issue by using a fallible conversion, defaulting to 0 if the conversion fails. It changes the following: - Replace cast in `Array.splice` prototype method with fallible conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes a faulty cast for
Array.splice.Negative values for delete_count were being directly casted to usize, which was not the intended behavior. This pull request fixes the issue by using a fallible conversion, defaulting to 0 if the conversion fails.
It changes the following:
Array.spliceprototype method with fallible conversion.