-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Indicate bigint has constructor #2008
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 45.89% 45.89%
=======================================
Files 206 206
Lines 17150 17150
=======================================
Hits 7871 7871
Misses 9279 9279
Continue to review full report at Codecov.
|
VM implementation
Fixed tests (2):
|
HalidOdat
approved these changes
Apr 5, 2022
HalidOdat
added
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
labels
Apr 5, 2022
HalidOdat
requested review from
jedel1043,
jasonwilliams,
RageKnify,
raskad and
Razican
April 5, 2022 07:38
raskad
approved these changes
Apr 5, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
This Pull Request changes BigInt so that isConstructor returns true. It changes a single boolean value for BigInt's ConstructorBuilder.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Indicate bigint has constructor
[Merged by Bors] - Indicate bigint has constructor
Apr 5, 2022
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This Pull Request changes BigInt so that isConstructor returns true. It changes a single boolean value for BigInt's ConstructorBuilder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes BigInt so that isConstructor returns true.
It changes a single boolean value for BigInt's ConstructorBuilder.