Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Indicate bigint has constructor #2008

Closed
wants to merge 1 commit into from

Conversation

lupd
Copy link
Contributor

@lupd lupd commented Apr 5, 2022

This Pull Request changes BigInt so that isConstructor returns true.

It changes a single boolean value for BigInt's ConstructorBuilder.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2008 (4112841) into main (ffc7a3e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files         206      206           
  Lines       17150    17150           
=======================================
  Hits         7871     7871           
  Misses       9279     9279           
Impacted Files Coverage Δ
boa_engine/src/builtins/bigint/mod.rs 79.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc7a3e...4112841. Read the comment docs.

@HalidOdat
Copy link
Member

VM implementation

Test result main count PR count difference
Total 88,650 88,650 0
Passed 44,003 44,005 +2
Ignored 21,711 21,711 0
Failed 22,936 22,934 -2
Panics 0 0 0
Conformance 49.64% 49.64% +0.00%
Fixed tests (2):
test/built-ins/BigInt/is-a-constructor.js [strict mode] (previously Failed)
test/built-ins/BigInt/is-a-constructor.js (previously Failed)

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 5, 2022
@HalidOdat HalidOdat added this to the v0.15.0 milestone Apr 5, 2022
@raskad
Copy link
Member

raskad commented Apr 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2022
This Pull Request changes BigInt so that isConstructor returns true.

It changes a single boolean value for BigInt's ConstructorBuilder.
@bors
Copy link

bors bot commented Apr 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Indicate bigint has constructor [Merged by Bors] - Indicate bigint has constructor Apr 5, 2022
@bors bors bot closed this Apr 5, 2022
@lupd lupd deleted the constructor branch April 5, 2022 18:00
Razican pushed a commit that referenced this pull request Jun 8, 2022
This Pull Request changes BigInt so that isConstructor returns true.

It changes a single boolean value for BigInt's ConstructorBuilder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants