[Merged by Bors] - Allow boolean/null as property identifier by dot operator assignment #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 45.93% 45.90% -0.04%
==========================================
Files 206 206
Lines 17138 17148 +10
==========================================
- Hits 7873 7872 -1
- Misses 9265 9276 +11
Continue to review full report at Codecov.
|
VM implementation
Fixed tests (2): |
HalidOdat
added
bug
HalidOdat
requested review from
Razican,
HalidOdat,
jasonwilliams,
jedel1043,
RageKnify and
raskad
HalidOdat
approved these changes
Mar 29, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
…1985) This Pull Request lets true/false/null be used as object property identifiers, when using dot assignment. `foo.null = 'bar';` It changes the following: - AST parsing of member expressions
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
…1985) This Pull Request lets true/false/null be used as object property identifiers, when using dot assignment. `foo.null = 'bar';` It changes the following: - AST parsing of member expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request lets true/false/null be used as object property identifiers, when using dot assignment.
foo.null = 'bar';It changes the following: