-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix try/catch/finally related bugs and add tests #1901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 46.41% 46.37% -0.04%
==========================================
Files 206 206
Lines 16790 16810 +20
==========================================
+ Hits 7793 7796 +3
- Misses 8997 9014 +17
Continue to review full report at Codecov.
|
Benchmark for cbb133dClick to view benchmark
|
jedel1043
added
bug
Something isn't working
execution
Issues or PRs related to code execution
vm
Issues and PRs related to the Boa Virtual Machine.
labels
Mar 6, 2022
raskad
approved these changes
Mar 6, 2022
HalidOdat
approved these changes
Mar 7, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes some bugs related to try blocks: - Fixes a panic when a finally block contained variable declarations. (Thanks to @VTCAKAVSMoACE for the report!) - Fixes a bug where try blocks in the last position of a statement list didn't return its inner last value as the result of the evaluation. - Add tests for both cases and two other common cases. - Extract and cleanup some code.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix try/catch/finally related bugs and add tests
[Merged by Bors] - Fix try/catch/finally related bugs and add tests
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes some bugs related to try blocks: