-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Make iterator spec complaint #1889
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Something isn't working
execution
Issues or PRs related to code execution
labels
Mar 2, 2022
Test262 conformance changesVM implementation
Fixed tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
- Coverage 46.61% 46.59% -0.02%
==========================================
Files 205 205
Lines 16726 16753 +27
==========================================
+ Hits 7796 7806 +10
- Misses 8930 8947 +17
Continue to review full report at Codecov.
|
Benchmark for 56da1dfClick to view benchmark
|
Benchmark for c8f9f2eClick to view benchmark
|
Benchmark for c344286Click to view benchmark
|
- Remove `JsValue::get_field()`
HalidOdat
requested review from
raskad,
Razican,
jedel1043,
jasonwilliams and
RageKnify
March 2, 2022 23:17
RageKnify
approved these changes
Mar 2, 2022
Benchmark for cf02e7fClick to view benchmark
|
jedel1043
approved these changes
Mar 3, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
This PR is also related to #577 Changes: - Implements `IteratorValue` (`IteratorResult::value()`) - Implements `IteratorComplete` (`IteratorResult::complete()`) - Implements `IteratorStep` (`IteratorRecord::step()`) - Makes `IteratorNext` (`IteratorRecord::next()`) spec compliant - Deprecates/removes `JsValue::get_field()`.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Make iterator spec complaint
[Merged by Bors] - Make iterator spec complaint
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is also related to #577
Changes:
IteratorValue
(IteratorResult::value()
)IteratorComplete
(IteratorResult::complete()
)IteratorStep
(IteratorRecord::step()
)IteratorNext
(IteratorRecord::next()
) spec compliantJsValue::get_field()
.