[Merged by Bors] - Added conversions from and to serde_json's Value type #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
+ Coverage 56.09% 56.29% +0.19%
==========================================
Files 200 201 +1
Lines 17901 17936 +35
==========================================
+ Hits 10042 10097 +55
+ Misses 7859 7839 -20
Continue to review full report at Codecov.
|
Benchmark for f680474Click to view benchmark
|
jedel1043
requested changes
Feb 20, 2022
|
Also, I think some module tests would be good to ensure conversions work OK |
RageKnify
approved these changes
Feb 21, 2022
I wrote the fixes and added a pretty deep test. Hopefully this should solve most situations. |
Benchmark for 6081edfClick to view benchmark
|
jedel1043
requested changes
Feb 21, 2022
Benchmark for 12bac5eClick to view benchmark
|
Benchmark for 8eff2bcClick to view benchmark
|
jedel1043
approved these changes
Feb 21, 2022
Benchmark for 55eb70fClick to view benchmark
|
Benchmark for 6be7440Click to view benchmark
|
Benchmark for d0593f4Click to view benchmark
|
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
This Pull Request closes #1693. It changes the following: - It adds a fallible conversion from `serde_json::Value` to `JsValue`, which requires a context. - It adds a fallible conversion from `JsValue` to `serde_json::Value`, which requires a context. - Added examples to the documentation of both methods. - Removed some duplicate and non-needed code that I found while doing this. Co-authored-by: RageKnify <RageKnify@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Benchmark for ab9d80dClick to view benchmark
|
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #1693.
It changes the following:
serde_json::ValuetoJsValue, which requires a context.JsValuetoserde_json::Value, which requires a context.