[Merged by Bors] - Added fallible allocation to data blocks #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Razican
requested review from
jasonwilliams,
HalidOdat,
Lan2u,
RageKnify,
raskad,
jedel1043,
0x7D2B and
tofpie
Codecov Report
@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
+ Coverage 53.28% 53.33% +0.04%
==========================================
Files 200 200
Lines 16982 16983 +1
==========================================
+ Hits 9049 9058 +9
+ Misses 7933 7925 -8
Continue to review full report at Codecov.
|
Test262 conformance changesNon-VM implementation
VM implementation
|
raskad
approved these changes
Dec 4, 2021
|
bors r+ |
|
👎 Rejected by too few approved reviews |
jedel1043
approved these changes
Dec 5, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 5, 2021
This Pull Request uses the new fallible allocation API in Rust 1.57 to follow the JavaScript specification for data blocks: https://tc39.es/ecma262/#sec-createbytedatablock It changes the following: - Creating a new DataBlock for an ArrayBuffer will no longer fail with an arbitrary byte length, it will now actually call the allocator and try to reserve the needed space, and fail if it can't. - Added sunny and rainy day unit tests that check if the API works as expected. - Bumped the minimum Rust version to Rust 1.57 for the Boa crate. - Removed the unused `DataBlock` implementation in IntegerIndexedObjects.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request uses the new fallible allocation API in Rust 1.57 to follow the JavaScript specification for data blocks: https://tc39.es/ecma262/#sec-createbytedatablock
It changes the following:
DataBlockimplementation in IntegerIndexedObjects.