Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Async Generator Parsing #1669

Merged
merged 45 commits into from
Oct 23, 2021
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
92e5a05
initial commit of attempt at AsyncGeneratorDeclaration and AsyncGener…
nekevss Oct 11, 2021
c80080c
fixed misspelled AsyncGeneratorDeclaration
nekevss Oct 12, 2021
059cd48
adding AsyncGeneratorDeclaration to hoistable
nekevss Oct 12, 2021
3a6ff05
removing unused Keyword from async_function_expression
nekevss Oct 12, 2021
86326c7
AsyncGeneratorExpr tests and cargo fmt
nekevss Oct 14, 2021
8b03415
fixing tests
nekevss Oct 15, 2021
94fbdad
added tests to mod and adding to module declarations
nekevss Oct 15, 2021
6dfeafe
Added AsyncGenerator and Async to MethodDefinitionKind
nekevss Oct 15, 2021
2b81c58
allwo await and yield set to true in async_gen_decl - cargo fmt
nekevss Oct 15, 2021
28b7e82
added new method kinds to object node
nekevss Oct 15, 2021
0bb3853
forgot cargo fmt
nekevss Oct 15, 2021
2b5ecb5
Added some better comments implementations
nekevss Oct 15, 2021
0391d57
added async and async generator methods to object_initializer
nekevss Oct 15, 2021
3124783
Added note to uniqueformalparameters:formalparameters error check
nekevss Oct 15, 2021
f47b79f
Opps, removed cursor ops that now happen before AsyncFunctionDeclarat…
nekevss Oct 15, 2021
557d5c0
made requested review changes
nekevss Oct 19, 2021
83e3092
initial commit of attempt at AsyncGeneratorDeclaration and AsyncGener…
nekevss Oct 11, 2021
408e3fc
fixed misspelled AsyncGeneratorDeclaration
nekevss Oct 12, 2021
f9b2183
adding AsyncGeneratorDeclaration to hoistable
nekevss Oct 12, 2021
6ff0cc6
removing unused Keyword from async_function_expression
nekevss Oct 12, 2021
adbcb41
AsyncGeneratorExpr tests and cargo fmt
nekevss Oct 14, 2021
3578a6e
fixing tests
nekevss Oct 15, 2021
d926ad2
added tests to mod and adding to module declarations
nekevss Oct 15, 2021
3dd5614
Added AsyncGenerator and Async to MethodDefinitionKind
nekevss Oct 15, 2021
ce04054
allwo await and yield set to true in async_gen_decl - cargo fmt
nekevss Oct 15, 2021
2ce5665
added new method kinds to object node
nekevss Oct 15, 2021
1f7cafc
forgot cargo fmt
nekevss Oct 15, 2021
a5d0c04
Added some better comments implementations
nekevss Oct 15, 2021
97e8eb3
added async and async generator methods to object_initializer
nekevss Oct 15, 2021
81418fa
Added note to uniqueformalparameters:formalparameters error check
nekevss Oct 15, 2021
3b2d110
Opps, removed cursor ops that now happen before AsyncFunctionDeclarat…
nekevss Oct 15, 2021
782541a
made requested review changes
nekevss Oct 19, 2021
7a43369
Merge branch 'impl-async-gen-parser' of https://github.com/nekevss/bo…
nekevss Oct 19, 2021
b37268a
fixing issue in async methods in object_initializer + tests
nekevss Oct 21, 2021
343d4f6
added a comment
nekevss Oct 21, 2021
74dedf8
Merge branch 'master' into impl-async-gen-parser
nekevss Oct 22, 2021
4cb76b2
review changes to match parser spec/clean up
nekevss Oct 23, 2021
a59405b
changes to comment blocks on async gen decl
nekevss Oct 23, 2021
35704be
cargo fmt
nekevss Oct 23, 2021
7abd657
Added to ByteCompiler & review changes
nekevss Oct 23, 2021
ac55423
Added TODO to PrimaryExpression
nekevss Oct 23, 2021
58b32dd
Removed inline attribute
nekevss Oct 23, 2021
5edcba5
Added more to comment blocks
nekevss Oct 23, 2021
7c89348
Update boa/src/syntax/ast/node/declaration/async_generator_expr/mod.rs
Razican Oct 23, 2021
1892ecd
Update boa/src/syntax/parser/statement/declaration/hoistable/async_ge…
Razican Oct 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added a comment
  • Loading branch information
nekevss committed Oct 21, 2021
commit 343d4f660ec49f34ef19f5d6ce2353b9f8edf6d3
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ where
return Ok(node::PropertyDefinition::SpreadObject(node));
}

//Async [AsyncMethod, AsyncGeneratorMethod] object methods
if cursor.next_if(Keyword::Async)?.is_some() {
cursor.peek_expect_no_lineterminator(0, "Async object methods")?;

Expand Down