Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new get_or_undefined method for [JsValue] #1492

Merged
merged 5 commits into from
Sep 6, 2021
Merged

Implement new get_or_undefined method for [JsValue] #1492

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d45527
Create `JsArgs` trait
jedel1043 Aug 22, 2021
10e8052
Implement trait `JsArgs` for `[JsValue]`
jedel1043 Aug 22, 2021
7984a92
Replace calls to `get/unwrap_or` with `get_or_undefined`
jedel1043 Aug 22, 2021
f4acddd
Return `&JsValue` from `get_or_undefined` instead of cloning
jedel1043 Aug 23, 2021
4535aa2
Replace more instances and document function
jedel1043 Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement trait JsArgs for [JsValue]
  • Loading branch information
@jedel1043
jedel1043 committed Aug 27, 2021
commit 10e80524e3903a35d831a839936b61f7fea15b67
6 changes: 6 additions & 0 deletions boa/src/builtins/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,9 @@ pub fn init(context: &mut Context) {
pub(crate) trait JsArgs {
fn get_or_undefined(&self, index: usize) -> JsValue;
}

impl JsArgs for [JsValue] {
fn get_or_undefined(&self, index: usize) -> JsValue {
self.get(index).cloned().unwrap_or_default()
}
}