Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add check_output test helper #1458

Merged
merged 8 commits into from
Aug 22, 2021
Merged

tests: add check_output test helper #1458

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
800afa9
tests: add check_output test helper
bartlomieju Aug 8, 2021
1662a4e
fmt
bartlomieju Aug 8, 2021
741c94c
Update boa/src/value/tests.rs
bartlomieju Aug 21, 2021
1ec19fe
rework check_output to use TestAction enum
bartlomieju Aug 21, 2021
68c2cd2
use check_output in boa/src/exec
bartlomieju Aug 21, 2021
e0386a9
Merge branch 'master' into check_output
bartlomieju Aug 21, 2021
b9f87e7
update docstring
bartlomieju Aug 21, 2021
bda306a
review
bartlomieju Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review
  • Loading branch information
@bartlomieju
bartlomieju committed Aug 21, 2021
commit bda306a556067cab9917c120a745154053f15b17
9 changes: 6 additions & 3 deletions boa/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ pub(crate) enum TestAction {
pub(crate) fn check_output(actions: &[TestAction]) {
let mut context = Context::new();

for (i, action) in actions.iter().enumerate() {
let mut i = 1;
for action in actions {
match action {
TestAction::Execute(src) => {
forward(&mut context, src);
Expand All @@ -185,17 +186,19 @@ pub(crate) fn check_output(actions: &[TestAction]) {
&forward(&mut context, case),
expected,
"Test case {} ('{}')",
i + 1,
i,
case
);
i += 1;
}
TestAction::TestStartsWith(case, expected) => {
assert!(
&forward(&mut context, case).starts_with(expected),
"Test case {} ('{}')",
i + 1,
i,
case
);
i += 1;
}
}
}
Expand Down