Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider panic fixes as "new failures" #1294

Merged
merged 5 commits into from
May 30, 2021
Merged

Don't consider panic fixes as "new failures" #1294

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9152734
Don't consider panic fixes as "new failures"
Razican May 29, 2021
26df210
Improved coding style
Razican May 29, 2021
2c59f33
Fixed Test262 tester for the testing update
Razican May 30, 2021
c737bf8
Ignore JSON module tests
Razican May 30, 2021
ab6ce0c
Test262 uses _FIXTURE at any point of the file name
Razican May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't consider panic fixes as "new failures"
  • Loading branch information
@Razican
Razican committed May 29, 2021
commit 91527340a4ef71c7837443bc09c3c5fd783222d6
6 changes: 5 additions & 1 deletion boa_tester/src/results.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,10 +433,14 @@ fn compute_result_diff(
| (TestOutcomeResult::Failed, TestOutcomeResult::Failed)
| (TestOutcomeResult::Panic, TestOutcomeResult::Panic) => {}

(TestOutcomeResult::Panic, TestOutcomeResult::Failed) => {
final_diff.panic_fixes.push(test_name)
}

(_, TestOutcomeResult::Passed) => final_diff.fixed.push(test_name),
(_, TestOutcomeResult::Failed) => final_diff.broken.push(test_name),
(_, TestOutcomeResult::Panic) => final_diff.new_panics.push(test_name),
(TestOutcomeResult::Panic, _) => final_diff.panic_fixes.push(test_name),

_ => {}
}
}
Expand Down