-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Symbol builtin #1234
Merged
Merged
Separate Symbol builtin #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
requested review from
Razican,
jasonwilliams,
Lan2u,
RageKnify,
0x7D2B and
tofpie
May 7, 2021 23:02
Test262 conformance changes:
|
Benchmark for e933b6eClick to view benchmark
|
RageKnify
approved these changes
May 8, 2021
Razican
approved these changes
May 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) just needs a re-base.
HalidOdat
force-pushed
the
separate-symbol-builtin
branch
from
May 8, 2021 22:30
821d7f0
to
05ef50c
Compare
Benchmark for 0619ac2Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
symbol
moduleRcSymbol
fromvalue
module tosymbol
moduleThis is done so we don't mix the builtin Symbol stuff with the way we store Symbol. like #689