-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RegExp flag accessors #1221
Conversation
Test262 conformance changes:
|
Benchmark for 9b6ea3dClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume the panics are the 2 ghosts that keep showing up in CI.
edit: panics disappeared...
Benchmark for 05b5601Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just noticed a couple of things that might require a small fix.
Benchmark for cb36796Click to view benchmark
|
It changes the following:
RegExp.prototype.global
accessorRegExp.prototype.multiline
accessorRegExp.prototype.dotAll
accessorRegExp.prototype.ignoreCase
accessorRegExp.prototype.unicode
accessorRegExp.prototype.sticky
accessorRegExp.prototype.flags
accessor