Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attributes on properties of functions and constructors #1023

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Fix attributes on properties of functions and constructors #1023

merged 1 commit into from
Jan 1, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 1, 2021

This Pull Request fixes the attributes on properties length and name of functions and constructors. These properties should be configurable (see spec for length and spec for name).

It changes the following:

  • Default attributes of name and length for functions and constructors
  • Add name property to built-ins functions

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1023 (cb54e4d) into master (57d5679) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   60.23%   60.26%   +0.02%     
==========================================
  Files         169      169              
  Lines       11408    11412       +4     
==========================================
+ Hits         6872     6877       +5     
+ Misses       4536     4535       -1     
Impacted Files Coverage Δ
boa/src/object/mod.rs 51.51% <66.66%> (+0.27%) ⬆️
boa/src/builtins/function/mod.rs 75.72% <100.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d5679...ba87bd4. Read the comment docs.

@RageKnify RageKnify added the builtins PRs and Issues related to builtins/intrinsics label Jan 1, 2021
@RageKnify RageKnify added this to the v0.11.0 milestone Jan 1, 2021
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 22,657 23,335 +678
Ignored 15,585 15,585 0
Failed 40,251 39,573 -678
Panics 364 364 0
Conformance 28.86 29.73 +0.86%

@Razican Razican merged commit e0a135e into boa-dev:master Jan 1, 2021
@tofpie tofpie deleted the fix-fn-prop-attr branch January 1, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants