Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison with infinity #1001

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Fix comparison with infinity #1001

merged 1 commit into from
Dec 27, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 27, 2020

This Pull Request fixes/closes #1000 .

It changes the following:

  • Comparison between numbers

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #1001 (36eac72) into master (f34e0b5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1001   +/-   ##
=======================================
  Coverage   59.95%   59.95%           
=======================================
  Files         166      166           
  Lines       10857    10857           
=======================================
  Hits         6509     6509           
  Misses       4348     4348           
Impacted Files Coverage Δ
boa/src/builtins/number/mod.rs 63.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34e0b5...36eac72. Read the comment docs.

@RageKnify
Copy link
Contributor

RageKnify commented Dec 27, 2020

Leaving here for accessibility.

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,634 19,644 +10
Ignored 15,585 15,585 0
Failed 43,274 43,264 -10
Panics 430 430 0
Conformance 25.01 25.03 +0.01%

I assume a tarpaulin bug is making it so the changed code isn't seen as hit by the tests.

@RageKnify RageKnify added bug Something isn't working execution Issues or PRs related to code execution labels Dec 27, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican Razican added this to the v0.11.0 milestone Dec 27, 2020
@Razican Razican merged commit 880f652 into boa-dev:master Dec 27, 2020
@tofpie tofpie deleted the fix-infinity branch December 27, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad comparison with infinity
3 participants