Skip to content

Commit

Permalink
Fix eval attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
raskad committed Jun 19, 2022
1 parent d173e08 commit 7b6a9a5
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions boa_engine/src/builtins/eval/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
//! [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval
use crate::{
builtins::{function::Function, BuiltIn, JsArgs},
object::{JsObject, ObjectData},
builtins::{BuiltIn, JsArgs},
object::FunctionBuilder,
property::Attribute,
Context, JsValue,
};
Expand All @@ -24,20 +24,18 @@ pub(crate) struct Eval;
impl BuiltIn for Eval {
const NAME: &'static str = "eval";

const ATTRIBUTE: Attribute = Attribute::READONLY
const ATTRIBUTE: Attribute = Attribute::CONFIGURABLE
.union(Attribute::NON_ENUMERABLE)
.union(Attribute::PERMANENT);
.union(Attribute::WRITABLE);

fn init(context: &mut Context) -> Option<JsValue> {
let _timer = Profiler::global().start_event(Self::NAME, "init");

let object = JsObject::from_proto_and_data(
context.intrinsics().constructors().function().prototype(),
ObjectData::function(Function::Native {
function: Self::eval,
constructor: false,
}),
);
let object = FunctionBuilder::native(context, Self::eval)
.name("eval")
.length(1)
.constructor(false)
.build();

Some(object.into())
}
Expand Down

0 comments on commit 7b6a9a5

Please sign in to comment.