Add ENUM ComTyp And Rename ENUM Typ To BoTyp #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
commented
Mar 20, 2025
Collaborator
Author
|
There was a problem hiding this comment.
Pull Request Overview
This pull request renames references from the generic "Typ" enumeration to "BoTyp" and introduces a new "ComTyp" enumeration.
- Renames "Typ" to "BoTyp" in multiple business object files.
- Adds the "ComTyp" enumeration export in the init.py file.
Reviewed Changes
Copilot reviewed 99 out of 100 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/bo4e/init.py | Replaces "Typ" with "BoTyp" and adds "ComTyp" to the export list. |
| src/bo4e/bo/bilanzierung.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/buendelvertrag.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/preisblattdienstleistung.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/marktlokation.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/energiemenge.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/geraet.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/netzlokation.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/messlokation.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/kosten.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/person.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/fremdkosten.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/preisblatt.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/ausschreibung.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/geschaeftspartner.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/angebot.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/lokationszuordnung.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/lastgang.py | Updates the type annotation and default assignment from Typ to BoTyp. |
| src/bo4e/bo/marktteilnehmer.py | Updates the type annotation and default assignment from Typ to BoTyp. |
Files not reviewed (1)
- docs/contributing_guide.rst: Language not supported
hf-krechan
changed the title
hf-krechan
commented
Mar 21, 2025
Contributor
|
ist das vllt die gelegenheit endlich festzulegen, was ein COM und was ein BO ist und warum? die frage drängt sich ja förmlich auf. |
…_typ_com_and_typ_bo
…_typ_com_and_typ_bo
Collaborator
Author
done in 26a7992 Beschlossen im letzten Workshop in Hannover vom 2024-10-08.
|
hf-aschloegl
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.