✨👷♂️Add Github action step to check the version tag consistency #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
approved these changes
May 13, 2024
Contributor
hf-kklein
left a comment
hf-kklein
left a comment
There was a problem hiding this comment.
lgtm. melde dich, wenn ich es wirklich reviewen soll
hf-krechan
approved these changes
May 14, 2024
.github/workflows/python-publish.yml
Outdated
Comment on lines
46
to
47
| pip install tox | ||
| pip install -r requirements.txt -r docs/requirements.txt |
Collaborator
There was a problem hiding this comment.
what happened with the indentation here?
hf-krechan
reviewed
May 14, 2024
docs/compatibility/versioning.py
Outdated
Comment on lines
257
to
258
| def test_compare_work_tree_with_latest_version(): | ||
| compare_work_tree_with_latest_version("v202401.1.2-rc3", gh_token=None) |
Collaborator
There was a problem hiding this comment.
Would it make sense to create an extra test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #784