Skip to content

Remove SigmoidParameter.calculate #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024
Merged

Remove SigmoidParameter.calculate #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c362b22
Remove `SigmoidParameter.calculate`
hf-kklein May 7, 2024
f0d8a6d
Update test_sigmoidparameter.py
hf-kklein May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/bo4e/com/sigmoidparameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,3 @@ class Sigmoidparameter(COM):
B: Optional[Decimal] = None #: Wendepunkt für die bepreiste Menge (kW)
C: Optional[Decimal] = None #: Exponent (einheitenlos)
D: Optional[Decimal] = None #: Briefmarke Transportnetz (EUR/kWh)

def calculate(self, leistung: Decimal) -> Decimal:
"""
calculates LP
:param leistung: Leistung in Kilowatt
:return: den Sigmoidparameter LP in EUR/kWh
"""
if self.A is None or self.B is None or self.C is None or self.D is None:
raise ValueError("Sigmoidparameter is not fully defined")
return self.A / (1 + (leistung / self.B) ** self.C) + self.D
18 changes: 0 additions & 18 deletions tests/test_sigmoidparameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,3 @@ def test_sigmoidparameter_serialization_roundtrip(self, sigmoidparameter: Sigmoi
Test de-/serialisation of Sigmoidparameter with minimal attributes.
"""
assert_serialization_roundtrip(sigmoidparameter)

@pytest.mark.parametrize(
"sigmoidparameter, leistung, expected_lp",
[
pytest.param(
Sigmoidparameter(
A=Decimal(1),
B=Decimal(3),
C=Decimal(3),
D=Decimal(4),
),
Decimal(3),
Decimal(4.5),
),
],
)
def test_lp_calculation(self, sigmoidparameter: Sigmoidparameter, leistung: Decimal, expected_lp: Decimal) -> None:
assert sigmoidparameter.calculate(leistung) == expected_lp