Skip to content

Conversation

@lord-haffi
Copy link
Collaborator

Resolves #488

Note: The code is written such that it should be easy to extend the compatibility matrix with another table listing the exact changes which were detected. There are several different ChangeTypes e.g. when the doc-string changed. However, I will leave that for another PR in the future.

@lord-haffi lord-haffi self-assigned this Mar 23, 2024
@lord-haffi lord-haffi added the documentation Improvements or additions to documentation label Mar 23, 2024
@lord-haffi
Copy link
Collaborator Author

It works! Finally :) You can take a look at it here: https://bo4e.github.io/BO4E-python/test-453436/changelog.html

@lord-haffi
Copy link
Collaborator Author

I will add the Python files to linting and type checking and resolve issues. But you can start to review the code.

@lord-haffi lord-haffi marked this pull request as ready for review April 22, 2024 20:49
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like :)👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich glaube, unsere Zielgruppe sind zwar developer, aber wir erreichen mehr der Leute, die wir neu erreichen wollen mit BO4E, wenn wir das auf Deutsch schreiben.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Berechtigter Einwand, dann müsste man den Rest der Doku aber auch ins Deutsche übersetzen. Die anderen Sachen sind nämlich auch alle auf Englisch ^^

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich lasse es für diesen PR mal auf Englisch, oder? Dann kann man die Aufgabe "Übersetze die Doku ins Deutsche" in einem Rutsch machen.

@lord-haffi lord-haffi enabled auto-merge (squash) April 29, 2024 18:13
@lord-haffi lord-haffi merged commit 4c6018f into main Apr 29, 2024
@lord-haffi lord-haffi deleted the compatibility_matrix branch April 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically build a matrix that visualizes the diffs between two versions on a BO basis

3 participants