Rework Geschaeftspartner, Marktteilnehmer and Ansprechpartner (=> Person) #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r' of https://github.com/bo4e/BO4E-python into ansprechpartner-mensch-marktteilnehmer-geschaeftspartner
hf-krechan
reviewed
Feb 6, 2024
hf-krechan
reviewed
Feb 6, 2024
hf-krechan
reviewed
Feb 6, 2024
src/bo4e/bo/geschaeftspartner.py
Outdated
| #: Adressen der Geschäftspartner, an denen sich der Hauptsitz befindet | ||
| partneradresse: Optional[Adresse] = None # todo: is it plural or not? the docs are bad | ||
| #: Todo: Add optional connection to marktteilnehmer as discussed in workshop | ||
| #: not clear what is the best solution here - circular import marktteilnehmer or adresse in kontakt? |
Collaborator
There was a problem hiding this comment.
ist ein technisches Problem, wird sich fachlich aber gewünscht.
Wir versuchen daher hier eine technische Lösung zu finden.
hf-krechan
reviewed
Feb 6, 2024
…h-marktteilnehmer-geschaeftspartner
and rename firmenname to organisationsname
Co-authored-by: kevin <68426071+hf-krechan@users.noreply.github.com>
Co-authored-by: kevin <68426071+hf-krechan@users.noreply.github.com>
hf-aschloegl
approved these changes
Feb 7, 2024
Collaborator
hf-aschloegl
left a comment
hf-aschloegl
left a comment
There was a problem hiding this comment.
Wie im Workshop gemeinsam besprochen und reviewed
hf-fvesely
deleted the
ansprechpartner-mensch-marktteilnehmer-geschaeftspartner
branch
This was referenced Apr 21, 2024
hf-fvesely
commented
Jul 30, 2024
|
|
||
| ist_gewerbe: Optional[bool] = None | ||
| ansprechpartner: Optional[list[Person]] = None | ||
| organisationstyp: Optional[Organisationstyp] = None |
Contributor
Author
There was a problem hiding this comment.
@hf-sheese Hier ist die Stelle, die wir suchen.
hf-fvesely
commented
Jul 30, 2024
| name1: Optional[str] = None | ||
| #: Mögliche Anrede der Person | ||
| anrede: Optional[Anrede] = None | ||
| individuelle_anrede: Optional[str] = None |
Contributor
Author
There was a problem hiding this comment.
Und hier ist die neue individuelle_anrede @hf-sheese
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Plan:
