plan: Fix date_format type infer (pingcap#2152)

See: http://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_date-format
bo11zhou · Dec 2, 2016 · d1b5f05 · d1b5f05
1 parent 8f499c9
commit d1b5f05
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/plan/typeinferer.go b/plan/typeinferer.go
@@ -309,7 +309,7 @@ func (v *typeInferrer) handleFuncCallExpr(x *ast.FuncCallExpr) {
 	case "dayname", "version", "database", "user", "current_user",
 		"concat", "concat_ws", "left", "lcase", "lower", "repeat",
 		"replace", "ucase", "upper", "convert", "substring",
-		"substring_index", "trim", "ltrim", "rtrim", "reverse", "hex", "unhex":
+		"substring_index", "trim", "ltrim", "rtrim", "reverse", "hex", "unhex", "date_format":
 		tp = types.NewFieldType(mysql.TypeVarString)
 		chs = v.defaultCharset
 	case "strcmp", "isnull":

diff --git a/plan/typeinferer_test.go b/plan/typeinferer_test.go
@@ -146,6 +146,7 @@ func (ts *testTypeInferrerSuite) TestInferType(c *C) {
 		{"hex(12)", mysql.TypeVarString, "utf8"},
 		{"unhex('TiDB')", mysql.TypeVarString, "utf8"},
 		{"unhex(12)", mysql.TypeVarString, "utf8"},
+		{"DATE_FORMAT('2009-10-04 22:23:00', '%W %M %Y')", mysql.TypeVarString, "utf8"},
 	}
 	for _, ca := range cases {
 		ctx := testKit.Se.(context.Context)