Fix UB after libstd change #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::net::Ipv4Addr and std::net::Ipv6Addr are no longer transparent wrappers around their respective libc types. Construct them manually rather than through casting. Fixes #9.
bnoordhuis
added a commit
to bnoordhuis/deno
that referenced
this pull request
Sep 12, 2022
v0.1.3 contains code that will stop working with newer versions of libstd because the layout of some std::net types changed. Refs: bnoordhuis/netif#10
bnoordhuis
added a commit
to bnoordhuis/deno
that referenced
this pull request
Sep 13, 2022
v0.1.3 contains code that will stop working with newer versions of libstd because the layout of some std::net types changed. Refs: bnoordhuis/netif#10
bnoordhuis
added a commit
to bnoordhuis/deno
that referenced
this pull request
Sep 19, 2022
v0.1.3 contains code that will stop working with newer versions of libstd because the layout of some std::net types changed. Refs: bnoordhuis/netif#10
cjihrig
pushed a commit
to denoland/deno
that referenced
this pull request
Sep 19, 2022
v0.1.3 contains code that will stop working with newer versions of libstd because the layout of some std::net types changed. Refs: bnoordhuis/netif#10
dsherret
pushed a commit
to dsherret/deno
that referenced
this pull request
Sep 22, 2022
v0.1.3 contains code that will stop working with newer versions of libstd because the layout of some std::net types changed. Refs: bnoordhuis/netif#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::net::Ipv4Addr and std::net::Ipv6Addr are no longer transparent wrappers around their respective libc types. Construct them manually rather than through casting.
Fixes #9.