get latest update #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm not sure why you're sending me this. This is my development fork; it's just feature branches, nothing more. |
In Linux, simple/test-child-process-fork-net2.js fails intermittently. In SuSE Linux system, under network high load situations, this failure is consistently reproducible. The test case tests whether the TCP connections which were established between the processes terminate in a timely and clean manner. After some iterations of data transfer on established connections, the server is closed. The server does not get closed immediately, instead waits for all the active connections to terminate. A timed (200ms) callback closes the connections, which eventually closes the server. The start is the time when the server close is invoked. The end is the time when the server is actually closed(onClose call back invoked). Given that there is a minimum delay of 200ms before the connections are terminated, expecting the elapsed time above 190 is reasonable and fair, but looks like the leeway of 800ms for the upper bounds seem to be too stringent, and breaking some scenarios of network load. Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs/node-v0.x-archive#14129
Disable RC4 in the default cipher list Add the `--cipher-list` command line switch and `NODE_CIPHER_LIST` environment variable to completely override the default cipher list. Add the `--enable-legacy-cipher-list` and `NODE_LEGACY_CIPHER_LIST` environment variable to selectively enable the default cipher list from previous node.js releases. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node-v0.x-archive#14413
Per feedback on the commit, make the PrintHelp for --enable-legacy-cipher-list less verbose. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node-v0.x-archive#14413
Disable RC4 in the default cipher list Add the `--cipher-list` command line switch and `NODE_CIPHER_LIST` environment variable to completely override the default cipher list. Add the `--enable-legacy-cipher-list` and `NODE_LEGACY_CIPHER_LIST` environment variable to selectively enable the default cipher list from previous node.js releases. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node-v0.x-archive#14414
Per feedback on the commit, make the PrintHelp output for --enable-legacy-cipher-list less verbose. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node-v0.x-archive#14414
Added link to workflow guidelines page in API docs' navigation menu. Fixes nodejs/nodejs.org-archive#102. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs/node-v0.x-archive#14570
simple/test-child-process-stdout-flush-exit.js fails with an assertion. The root cause for this assertion is that the expected boolean value of true for the variable gotBye was false. This is set to true when the piped stdout stream of the child writes the end token "goodbye". So the error message would indicate that the end token was never received by the parent, but in fact it did. The only difference is that the first chunk itself had both 'hello' and 'goodbye' (as well as the filler words in between) in AIX, while Linux receives them separately. While this issue is not reproducible in Linux, the number of bytes received each time a callback is called is not consistent across runs, which is ratified as the actual content size of a UNIX domain data packet is determined outside of the node's logic, instead in OS tunables, as well as the runtime context of data transfer (depending on contigeous free memory available in OS data structures at the time of sending). In addition, around 200 filler words sent in between the 'hello' and 'goodbye' seem to indicate that the coalescence of chunks was a possibility in Linux as well, and was devised to separate the first word from the last, through an arbitrary delimiter. Parser logic seem to be rigid and have assumptions about the order and size of the data arrival. For example, it checks for 'goodbye' only when it does not find 'hello' in it, as if they would always come separately. This exclusiveness is what makes the test to fail in AIX. Reviewed-By: PR-URL: nodejs/node-v0.x-archive#14410
This is a backport of ea37ac0 Original commit message: On AIX, OS X and the BSDs, calling shutdown() on one end of a pipe when the other end has closed the connection fails with ENOTCONN. The sequential/test-child-process-execsync test failed sporadically because of a race between the parent and the child where one closed its end of the pipe before the other got around to calling shutdown() on its end of the pipe. Libuv is not the right place to handle that because it can't tell if the ENOTCONN error is genuine but io.js can. Refs: libuv/libuv#268 PR-URL: iojs#1214 Reviewed-By: Bert Belder <bertbelder@gmail.com> Fixes: nodejs/node-v0.x-archive#9444. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs/node-v0.x-archive#14480
Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs/node-v0.x-archive#14172
When debug in remote mode with host:port or pid, the interface spawn child process also. If the debugger agent is running, will get following output: ``` < Error: listen EADDRINUSE :::5858 < at Object.exports._errnoException (util.js:734:11) < at exports._exceptionWithHostPort (util.js:757:20) < at Agent.Server._listen2 (net.js:1155:14) < at listen (net.js:1181:10) < at Agent.Server.listen (net.js:1268:5) < at Object.start (_debug_agent.js:21:9) < at startup (node.js:68:9) < at node.js:799:3 ``` This fix won't spawn child process and no more error message was shown. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs/node-v0.x-archive#14172
61fe1fe backported b64983d from io.js, but failed to change nullptr to NULL, which lead to a build break on FreeBSD since the current build system doesn't enable support for C++11. This change replaces nullptr by NULL, and has been tested on FreeBSD 10.1-RELEASE-p8. Fixes #9326. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs/node-v0.x-archive#14819
Add separate sample code for the write-after-end case to avoid confusion. PR: #15517 PR-URL: nodejs/node-v0.x-archive#15517 Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR: #14089 PR-URL: nodejs/node-v0.x-archive#14089 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR: #14089 PR-URL: nodejs/node-v0.x-archive#14089 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR-URL: nodejs/node-v0.x-archive#20109
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes #8540 and #9204. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs/node-v0.x-archive#18204
The 3.28.73 update was technically unstable code. This reverts the code to the latest 3.28 stable release. Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: nodejs/node-v0.x-archive#18206
Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: nodejs/node-v0.x-archive#18206
Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: nodejs/node-v0.x-archive#18206
Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: nodejs/node-v0.x-archive#18206
Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8. Original commit message: Fix Unhandled ReferenceError in debug-debugger.js This fixes following exception in Sky on attempt to set a breakpoint "Unhandled: Uncaught ReferenceError: break_point is not defined" I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode. BUG=None LOG=N R=yangguo@chromium.org Review URL: https://codereview.chromium.org/741683002 Cr-Commit-Position: refs/heads/master@{#25415} Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: nodejs/node-v0.x-archive#18206
This change in V8: https://code.google.com/p/v8/source/detail?r=22210 has introduced a method named OS::GetCurrentThreadId which fails to compile on OSes where a "gettid" syscall does not exist. This build issue has been fixed upstream by several changes: - https://code.google.com/p/v8/source/detail?r=23459. - https://codereview.chromium.org/649553002 - https://codereview.chromium.org/642223003 Another minor fix to the upstream changes was also necessary. See https://code.google.com/p/v8/issues/detail?id=3620 for more information. The other build issue was due to the fact that alloca.h is not included by other system includes on SmartOS, which is assumed by V8. Built and tested on Linux, MacOS X, Windows and SmartOS. Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: nodejs/node-v0.x-archive#18206
Backport b17eaaa5755e625493c5fe537f42b58838923c52 from upstream v8. Original commit message: Fix desugaring of let bindings in for loops to handle continue properly This requires putting the original loop's body inside an inner for loop (with the same labels as the original loop) and re-binding the temp variables in its "next" expression. A second flag is added to the desugared code to ensure the loop body executes at most once per loop. BUG=v8:3683 LOG=y Review URL: https://codereview.chromium.org/720863002 Cr-Commit-Position: refs/heads/master@{#25363} Fixes #9113 and #14411. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs/node-v0.x-archive#23948
072460265226c047369558b23e9ff2748965bf6c floats a patch on V8 that fixes issue #9113 that would cause let bindings and continue statements in for loops to not work properly. This change adds a regression test that fails if that patch is not properly floated, thus preventing us from not floating that patch after future V8 upgrades. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs/node-v0.x-archive#23948
When running make test-npm, make would use the node binary available in the PATH, which would most of the time not be the same binary as the one built from the source tree from where the make test-npm command in run. This can be confusing, as it can lead users to think that they tested npm with the version of node that was built from the current checkout of the source tree when it would actually run the tests with a completely different version. This change modifies the PATH environment variable for all commands that need to run the node binary to run npm's tests by adding the root of the local checkout as the first entry, so that the custom built node is always used. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs/node-v0.x-archive#9107
Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs/node-v0.x-archive#20311
The loopback on AIX is slower by default than on other platforms and we've seen a number of tests fail on AIX for this reason. This looks to be another instance. Changing the test to bind to the host ip instead of the loopback makes it pass reliably. This change extends the timeout so that it passes reliably on AIX even with the slower loopback behaviour modified: test/simple/test-tls-wrap-timeout.js Reviewed-By: coln Ihrig <cjihrig@gmail.com> PR-URL: nodejs/node-v0.x-archive#25138
This is needed so that we can backport 668bde8 from io.js with a clean merge. PR-URL: nodejs/node-v0.x-archive#25100 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Fixes: nodejs/node-v0.x-archive#4356
Backport 668bde8 from io.js. Original commit message follows: In theory the msi should broadcast a 'WM_SETTINGCHANGE' message to all windows after modifying the PATH environment variable. This ensures that the new PATH is visible to other processes without restarting windows (although it's still necessary to close and reopen active console windows). Unfortunately, the broadcast doesn't always happen, for unknown reasons. That's why this patch adds a custom action that unconditionally broadcasts a WM_SETTINGCHANGE message. Bug: #603 PR: #613 Reviewed-by: Bert Belder <bertbelder@gmail.com> (cherry picked from commit 668bde8) --Node.js commmit metadata-- PR-URL: nodejs/node-v0.x-archive#25100 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Fixes: nodejs/node-v0.x-archive#4356
This just replaces all sources of openssl-1.0.1u.tar.gz into deps/openssl/openssl. PR-URL: #8718 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Myles Borins <mborins@us.ibm.com>
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: #8718 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Myles Borins <mborins@us.ibm.com>
sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. PR: #9451 PR-URL: nodejs/node-v0.x-archive#9451 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: nodejs/node-v0.x-archive#25523 Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: nodejs/node-v0.x-archive#25654 Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . PR: #9451 PR-URL: nodejs/node-v0.x-archive#9451 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: nodejs/node-v0.x-archive#25523 Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: nodejs/node-v0.x-archive#25654 Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
reapply b910613 PR: #9451 PR-URL: nodejs/node-v0.x-archive#9451 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: nodejs/node-v0.x-archive#25523 Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: nodejs/node-v0.x-archive#25654 Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. (cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74) Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node-v0.x-archive#25368
Back port of 7e9b0dd 3d6225 to v0.12. PR-URL: nodejs-private/node-private#47 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Douglas Wilson <doug@somethingdoug.com>
Previously, the reason argument passed to ServerResponse#writeHead was not being properly validated. One could pass CRLFs which could lead to http response splitting. This commit changes the behavior to throw an error in the event any invalid characters are included in the reason. CVE-2016-5325 PR-URL: nodejs-private/node-private#47 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Douglas Wilson <doug@somethingdoug.com>
CVE-2016-7099 PR-URL: nodejs-private/node-private#61 Reviewed-By: Rod Vagg <rod@vagg.org>
This makes sure that no uninitialized bytes are leaked when the specified `totalLength` input value is greater than the actual total length of the specified buffers array, e.g. in Buffer.concat([Buffer.alloc(0)], 100). PR-URL: nodejs-private/node-private#66 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Compile out hardware engines. Most are stubs that dynamically load the real driver but that poses a security liability when an attacker is able to create a malicious DLL in one of the default search paths. Backport of nodejs-private/node-private#58 PR-URL: nodejs-private/node-private#69 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/september-2016-security-releases/ for details on patched vulnerabilities. Notable changes: * buffer: Zero-fill excess bytes in new `Buffer` objects created with `Buffer.concat()` while providing a `totalLength` parameter that exceeds the total length of the original `Buffer` objects being concatenated. (Сковорода Никита Андреевич) * http: - CVE-2016-5325 - Properly validate for allowable characters in the `reason` argument in `ServerResponse#writeHead()`. Fixes a possible response splitting attack vector. This introduces a new case where `throw` may occur when configuring HTTP responses, users should already be adopting try/catch here. Originally reported independently by Evan Lucas and Romain Gaucher. (Evan Lucas) - Invalid status codes can no longer be sent. Limited to 3 digit numbers between 100 - 999. Lack of proper validation may also serve as a potential response splitting attack vector. Backported from v4.x. (Brian White) * openssl: - Upgrade to 1.0.1u, fixes a number of defects impacting Node.js: CVE-2016-6304 ("OCSP Status Request extension unbounded memory growth", high severity), CVE-2016-2183, CVE-2016-6303, CVE-2016-2178 and CVE-2016-6306. - Remove support for loading dynamic third-party engine modules. An attacker may be able to hide malicious code to be inserted into Node.js at runtime by masquerading as one of the dynamic engine modules. Originally reported by Ahmed Zaki (Skype). (Ben Noordhuis, Rod Vagg) * tls: CVE-2016-7099 - Fix invalid wildcard certificate validation check whereby a TLS server may be able to serve an invalid wildcard certificate for its hostname due to improper validation of `*.` in the wildcard string. Originally reported by Alexander Minozhenko and James Bunton (Atlassian). (Ben Noordhuis) PR-URL: nodejs-private/node-private#72
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 26, 2016
Original commit message:
Version 5.1.281.65 (cherry-pick)
Merged 85b8c2dc4aee1031ac02f9d7c02d5c1aa76bc2ba
Fix observable array access when formatting stack trace.
BUG=chromium:617527
LOG=N
R=hablich@chromium.org
Review URL: https://codereview.chromium.org/2051383002 .
Cr-Commit-Position: refs/branch-heads/5.1@{nodejs#76}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{nodejs#35282}
PR-URL: nodejs#8078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
bnoordhuis
pushed a commit
that referenced
this pull request
Mar 23, 2017
Original commit message: Merged: [heap] Clear recorded slots for inobject properties when migrating fast object to slow mode. Revision: a814b8aeaf2b56635054c96435972dce90576f62 BUG=chromium:666046 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ulan@chromium.org Review URL: https://codereview.chromium.org/2549803002 . Cr-Commit-Position: refs/branch-heads/5.5@{nodejs#60} Cr-Branched-From: 3cbd5838bd8376103daa45d69dade929ee4e0092-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0ce2c9af0528837d8309625118d4096553b-refs/heads/master@{nodejs#40015} PR-URL: nodejs#10733 Reviewed-By: Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
bnoordhuis
pushed a commit
that referenced
this pull request
Apr 13, 2017
Original commit message: Merged: [heap] Clear recorded slots for inobject properties when migrating fast object to slow mode. Revision: a814b8aeaf2b56635054c96435972dce90576f62 BUG=chromium:666046 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ulan@chromium.org Review URL: https://codereview.chromium.org/2549803002 . Cr-Commit-Position: refs/branch-heads/5.5@{nodejs#60} Cr-Branched-From: 3cbd5838bd8376103daa45d69dade929ee4e0092-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0ce2c9af0528837d8309625118d4096553b-refs/heads/master@{nodejs#40015} PR-URL: nodejs#10733 Reviewed-By: Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 26, 2017
Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0x38(%rbp) 0x7fff96d0438f <+98>: movq 0x18(%rbp), %rcx (lldb) bt * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo + 179 frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255 frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179 frame nodejs#4: 0x00000001017d8888 cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at getaddrinfo.c:102 frame nodejs#5: 0x00000001017d880e cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8, cb=0x0000000000000000, hostname="nodejs.org", service="0", hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192 frame nodejs#6: 0x000000010171f781 cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658) + 801 at inspector_socket_server.cc:398 frame nodejs#7: 0x00000001016ed590 cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0) + 288 at test_inspector_socket_server.cc:593 I'm not sure about the exact cause for this but when using a standalone c program to simulate this it seems like when the ai_flags `AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc line 394, the servname (the port in the FailsToBindToNodejsHost test) is expected to be a numeric port string to avoid looking it up in /etc/services. When the port is 0 as is it was before this commit the segment fault occurs but not if it is non-zero. PR-URL: nodejs#16255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 29, 2017
Original commit message:
[PATCH] Merged: Make Object::GetOwnPropertyDescriptor() take a Name, not a String.
Revision: b5e610c19208ef854755eec67011ca7aff008bf4
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=vogelheim@chromium.org
Bug:
Change-Id: I396b559b28aab6afa138db747711e50cd0da3da7
Reviewed-on: https://chromium-review.googlesource.com/513927
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.0@{nodejs#5}
Cr-Branched-From: 97dbf624a5eeffb3a8df36d24cdb2a883137385f-refs/heads/6.0.286@{#1}
Cr-Branched-From: 12e6f1cb5cd9616da7b9d4a7655c088778a6d415-refs/heads/master@{nodejs#45439}
PR-URL: nodejs#13217
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 29, 2017
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{nodejs#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{nodejs#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{nodejs#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{nodejs#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{nodejs#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{nodejs#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Backport-PR-URL: nodejs#15393
PR-URL: nodejs#15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bnoordhuis
pushed a commit
that referenced
this pull request
Nov 14, 2017
Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0x38(%rbp) 0x7fff96d0438f <+98>: movq 0x18(%rbp), %rcx (lldb) bt * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo + 179 frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255 frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179 frame nodejs#4: 0x00000001017d8888 cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at getaddrinfo.c:102 frame nodejs#5: 0x00000001017d880e cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8, cb=0x0000000000000000, hostname="nodejs.org", service="0", hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192 frame nodejs#6: 0x000000010171f781 cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658) + 801 at inspector_socket_server.cc:398 frame nodejs#7: 0x00000001016ed590 cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0) + 288 at test_inspector_socket_server.cc:593 I'm not sure about the exact cause for this but when using a standalone c program to simulate this it seems like when the ai_flags `AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc line 394, the servname (the port in the FailsToBindToNodejsHost test) is expected to be a numeric port string to avoid looking it up in /etc/services. When the port is 0 as is it was before this commit the segment fault occurs but not if it is non-zero. PR-URL: nodejs#16255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
added a commit
that referenced
this pull request
Dec 15, 2017
Remove a pointless adapter frame by fixing up the function's formal
parameter count. Before:
frame #0: 0x000033257ea446d5 onParserExecute(...)
frame #1: 0x000033257ea3b93f <adaptor>
frame #2: 0x000033257ea41959 <internal>
frame #3: 0x000033257e9840ff <entry>
After:
frame #0: 0x00000956287446d5 onParserExecute(...)
frame #1: 0x0000095628741959 <internal>
frame #2: 0x00000956286840ff <entry>
bnoordhuis
added a commit
that referenced
this pull request
Dec 16, 2017
Remove a pointless adapter frame by fixing up the function's formal
parameter count. Before:
frame #0: 0x000033257ea446d5 onParserExecute(...)
frame #1: 0x000033257ea3b93f <adaptor>
frame #2: 0x000033257ea41959 <internal>
frame #3: 0x000033257e9840ff <entry>
After:
frame #0: 0x00000956287446d5 onParserExecute(...)
frame #1: 0x0000095628741959 <internal>
frame #2: 0x00000956286840ff <entry>
PR-URL: nodejs#17693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 29, 2018
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{nodejs#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{nodejs#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{nodejs#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{nodejs#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{nodejs#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{nodejs#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Backport-PR-URL: nodejs#15393
PR-URL: nodejs#15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bnoordhuis
added a commit
that referenced
this pull request
Mar 27, 2018
Remove a pointless adapter frame by fixing up the function's formal
parameter count. Before:
frame #0: 0x000033257ea446d5 onParserExecute(...)
frame #1: 0x000033257ea3b93f <adaptor>
frame #2: 0x000033257ea41959 <internal>
frame #3: 0x000033257e9840ff <entry>
After:
frame #0: 0x00000956287446d5 onParserExecute(...)
frame #1: 0x0000095628741959 <internal>
frame #2: 0x00000956286840ff <entry>
PR-URL: nodejs#17693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
bnoordhuis
pushed a commit
that referenced
this pull request
Mar 27, 2018
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{nodejs#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{nodejs#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{nodejs#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{nodejs#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{nodejs#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{nodejs#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Refs: nodejs#15393
PR-URL: nodejs#15393
Backport-PR-URL: nodejs#16413
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bnoordhuis
added a commit
that referenced
this pull request
Mar 27, 2018
Remove a pointless adapter frame by fixing up the function's formal
parameter count. Before:
frame #0: 0x000033257ea446d5 onParserExecute(...)
frame #1: 0x000033257ea3b93f <adaptor>
frame #2: 0x000033257ea41959 <internal>
frame #3: 0x000033257e9840ff <entry>
After:
frame #0: 0x00000956287446d5 onParserExecute(...)
frame #1: 0x0000095628741959 <internal>
frame #2: 0x00000956286840ff <entry>
PR-URL: nodejs#17693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 8, 2018
Reverting this enables us to provide slower, but longer-lasting
replacements for the deprecated APIs.
Original commit message:
Put back deleted V8_DEPRECATE_SOON methods
This partially reverts
https://chromium-review.googlesource.com/c/v8/v8/+/1177861,
which deleted many V8_DEPRECATE_SOON methods rather than moving them to
V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED.
Note V8_DEPRECATED that were deleted in the same CL stay deleted.
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: v8:7786, v8:8240
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I00330036d957f98dab403465b25e30d8382aac22
Reviewed-on: https://chromium-review.googlesource.com/1251422
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{nodejs#49}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{nodejs#55424}
Refs: v8/v8@9136dd8
Refs: nodejs#23122
PR-URL: nodejs#23158
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:)