Skip to content

Commit

Permalink
build: drop unconditional openssl dep from cctest
Browse files Browse the repository at this point in the history
Don't link in openssl when building `./configure --without-inspector`,
it's only used by the inspector cctests.  Ditto libuv and http_parser.

Fixes unnecessarily building openssl when `--shared-openssl` is also
passed to configure.

Fixes: nodejs#7478
PR-URL: nodejs#7486
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
bnoordhuis committed Jun 30, 2016
1 parent 3cac616 commit 7dcc4af
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -749,12 +749,7 @@
{
'target_name': 'cctest',
'type': 'executable',
'dependencies': [
'deps/openssl/openssl.gyp:openssl',
'deps/http_parser/http_parser.gyp:http_parser',
'deps/gtest/gtest.gyp:gtest',
'deps/uv/uv.gyp:libuv',
],
'dependencies': [ 'deps/gtest/gtest.gyp:gtest' ],
'include_dirs': [
'src',
'deps/v8/include'
Expand Down

0 comments on commit 7dcc4af

Please sign in to comment.