Revert Express autodetection #323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined user when there are multiple tumblelogs associated to the account.
…he existing module to make this one
Readme Fix for Google OAuth2
password was not being deleted.
include smarterer oauth
Changed github apiHost url and fetchOAuthUser to work with github api v3
added provider for dailycred.com
Fixed broken links
Fixed bug in the example code; saving a vimeo user
Added provider for weibo.com
…akinsella-master Conflicts: README.md example/conf.js example/server.js example/views/home.jade
Hi! I fixed some calls to "sys" for you!
corrected a typo in readme code sample
…into jonathana-meetup_oauth2 Conflicts: example/conf.js example/server.js example/views/home.jade
Added yahoohybrid
fix for issue bnoguchi#244 where the tumblr module is returning an undefined user when there are multiple tumblelogs associated to the account.
Rudimentary support for the Facebook Canvas
This reverts commit b854bc5.
|
+1. The Express autodetection doesn't work for me either. I'm using Express 2.x still. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I propose to revert the change that introduces Express autodetection while making helpExpress() a NOP function. Autodetection doesn't work for all usage scenarios and crashes working applications - see issue #322.
This reverts commit b854bc5.