Skip to content

Support specification of external user-defined macros #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support specification of external user-defined macros #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions source/tcppLibrary.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ namespace tcpp
public:
Preprocessor() TCPP_NOEXCEPT = delete;
Preprocessor(const Preprocessor&) TCPP_NOEXCEPT = delete;
Preprocessor(Lexer& lexer, const TPreprocessorConfigInfo& config) TCPP_NOEXCEPT;
Preprocessor(Lexer& lexer, const TPreprocessorConfigInfo& config, TSymTable userDefines = {}) TCPP_NOEXCEPT;
Copy link
Owner

@bnoazx005 bnoazx005 May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to move userDefines into TPreprocessorConfigInfo type to minimize number of arguments

~Preprocessor() TCPP_NOEXCEPT = default;

bool AddCustomDirectiveHandler(const std::string& directive, const TDirectiveHandler& handler) TCPP_NOEXCEPT;
Expand Down Expand Up @@ -1078,13 +1078,18 @@ namespace tcpp
};


Preprocessor::Preprocessor(Lexer& lexer, const TPreprocessorConfigInfo& config) TCPP_NOEXCEPT:
Preprocessor::Preprocessor(Lexer& lexer, const TPreprocessorConfigInfo& config, TSymTable userDefines) TCPP_NOEXCEPT:
mpLexer(&lexer), mOnErrorCallback(config.mOnErrorCallback), mOnIncludeCallback(config.mOnIncludeCallback), mSkipCommentsTokens(config.mSkipComments)
{
for (auto&& currSystemDefine : BuiltInDefines)
{
mSymTable.push_back({ currSystemDefine });
}

for (auto&& currUserDefine : userDefines)
{
mSymTable.push_back(currUserDefine);
}
}

bool Preprocessor::AddCustomDirectiveHandler(const std::string& directive, const TDirectiveHandler& handler) TCPP_NOEXCEPT
Expand Down Expand Up @@ -1984,4 +1989,4 @@ namespace tcpp
}

#endif
}
}