-
-
Notifications
You must be signed in to change notification settings - Fork 303
Do no longer consider distribution management repos by default #6946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Do no longer consider distribution management repos by default #6946
Conversation
72d0c22 to
bc1a003
Compare
This often leads to errors which break the build. Therefore this feature should be opt-in This closes bndtools#6945 Signed-off-by: Konrad Windszus <kwin@apache.org>
bc1a003 to
0c9a0ad
Compare
|
This is a breaking change. Is that really necessary since there is a configuration option to address your issue? |
|
I don't consider this an exceptional issue only on my side. Very often the distribution management URLs are not suitable for consumption. Often it is not even HTTP (but for example SCP:// or a custom transport handler like for https://github.com/maveniverse/njord). I would strongly suggest to have a default configuration which is less prone to errors (even if that means a breaking change). |
|
I have put it on the list potential breaking changes for a future 8.0 release https://github.com/bndtools/bnd/wiki/WIP-Ideas:-bnd-8.0.0-breaking-changes |
|
Maven Docs have been clarified recently in this regard: apache/maven-site#1466 |
Could you elaborate what this clarification in the maven docs means for this PR? |
|
That distribution URLs can only be used in edge cases for resolving/downloading. They are primarily thought for uploading! |
Ok that is my interpretation too based on apache/maven-site#1466 |
|
@timothyjward did the initial version of this plugin. So perhaps he can provide counsel on this change. |
This often leads to errors which break the build. Therefore this feature should be opt-in
This closes #6945