Skip to content

Conversation

@kwin
Copy link
Contributor

@kwin kwin commented Nov 18, 2025

This often leads to errors which break the build. Therefore this feature should be opt-in

This closes #6945

@kwin kwin force-pushed the bugfix/don't-include-distribution-mgmt-by-default branch from 72d0c22 to bc1a003 Compare November 18, 2025 15:32
This often leads to errors which break the build. Therefore this feature
should be opt-in

This closes bndtools#6945

Signed-off-by: Konrad Windszus <kwin@apache.org>
@kwin kwin force-pushed the bugfix/don't-include-distribution-mgmt-by-default branch from bc1a003 to 0c9a0ad Compare November 18, 2025 15:34
@bjhargrave
Copy link
Member

This is a breaking change. Is that really necessary since there is a configuration option to address your issue?

@kwin
Copy link
Contributor Author

kwin commented Nov 18, 2025

I don't consider this an exceptional issue only on my side. Very often the distribution management URLs are not suitable for consumption. Often it is not even HTTP (but for example SCP:// or a custom transport handler like for https://github.com/maveniverse/njord). I would strongly suggest to have a default configuration which is less prone to errors (even if that means a breaking change).

@chrisrueger
Copy link
Contributor

I have put it on the list potential breaking changes for a future 8.0 release https://github.com/bndtools/bnd/wiki/WIP-Ideas:-bnd-8.0.0-breaking-changes

@kwin
Copy link
Contributor Author

kwin commented Nov 21, 2025

Maven Docs have been clarified recently in this regard: apache/maven-site#1466

@chrisrueger
Copy link
Contributor

Maven Docs have been clarified recently in this regard: apache/maven-site#1466

Could you elaborate what this clarification in the maven docs means for this PR?
Sorry it might be obvious for a maven user familiar with the topic, but I am not.

@kwin
Copy link
Contributor Author

kwin commented Nov 21, 2025

That distribution URLs can only be used in edge cases for resolving/downloading. They are primarily thought for uploading!

@chrisrueger
Copy link
Contributor

That distribution URLs can only be used in edge cases for resolving/downloading. They are primarily thought for uploading!

Ok that is my interpretation too based on apache/maven-site#1466

@bjhargrave
Copy link
Member

@timothyjward did the initial version of this plugin. So perhaps he can provide counsel on this change.

@peterkir peterkir added the breakingchange PR introduce a breaking change, which need to be mentioned in release notes. label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange PR introduce a breaking change, which need to be mentioned in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bnd-baseline-maven-plugin: Do not consider Distribution Management repositories by default

4 participants