Effective view: Show multiple provenances when merged properties are enabled #6913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in the table: when mergedHeaders is enabled then the properties are grouped, thus for a single row there are multiple provenances relevant (the ones which are condensed into a single grouping). Now we show a list of provenances in this case. - double click opens the first entry (currently I don't see another way since I don't know how to detect where exactly the click happened Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
this formats the tooltip text according to the key e.g. for a known instruction like -buildpath it uses a formatter via BndEditModel.format() That way the tooltips look nicer and are more helpful - also: hovering: use stem to get the Syntax this allows to show helptext for keys with dots e.g. -plugin.a would still show the help text of the -plugin instruction and also point to the correct help url Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
chrisrueger
force-pushed
the
effective-provenance-for-merged
branch
from
de27999 to
a7a93ab
Compare
chrisrueger
changed the title
chrisrueger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effective View Improvements
Now we show a list of provenances in this case.
Also formats the tooltip text according to the key e.g. for a known instruction like
-buildpathit uses a formatter viaBndEditModel.format()That way the tooltips look nicer and are more helpful