use P2Exporter for org.bndtools.p2 #6808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
chrisrueger
force-pushed
the
6777-p2export-for-org.bndtools.p2
branch
from
ac557cf to
01c0ef2
Compare
chrisrueger
commented
Sep 16, 2025
chrisrueger
force-pushed
the
6777-p2export-for-org.bndtools.p2
branch
from
05ed7e5 to
c403602
Compare
chrisrueger
force-pushed
the
6777-p2export-for-org.bndtools.p2
branch
from
c403602 to
1335630
Compare
- use bnd's own P2Export https://bnd.bndtools.org/plugins/p2export.html for bnd itself the goal is to replace the veery old way of building the p2 artifact and use bnd itself. Importantly this solves the issue to use SHA-256 for checksum in addition to md5 to solve the Eclipse warning like "The digest algorithms (md5) used to verify ...jar have severely compromised security. Please report this concern to the artifact provider." - remove old p2 feature.xml files Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> Update bndtools.ecf.feature.bndrun Added reasonable version ranges for ecf features Signed-off-by: Scott Lewis <scottslewis@gmail.com> prepare p2 signing Step1: no signing (sign=false) but prepare the usage of environment variables , which might come from the GH Action workflow later. e.g. setting `P2_SIGN=true` env var enables the signing Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
chrisrueger
force-pushed
the
6777-p2export-for-org.bndtools.p2
branch
from
1335630 to
0a2942d
Compare
Contributor
Author
|
I will keep an eye on it and revert if there is something wrong. I will focus on the setup of P2 PGP Signing in a separte PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5156
Importantly this solves the issue to use SHA-256 for checksum in addition to md5 to solve the Eclipse warning like "The digest algorithms (md5) used to verify ...jar have severely compromised security. Please report this concern to the artifact provider." (#5156 )
Note: This PR is identical to (successor of) #6777 but this time created inside bndtools organization. This is needed so that we can use gpg variables for the P2 Signing