Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct witness and committer when gas account sending txs #233

Merged
merged 4 commits into from
Oct 28, 2022
Merged

fix: correct witness and committer when gas account sending txs #233

merged 4 commits into from
Oct 28, 2022

Conversation

forcodedancing
Copy link
Contributor

@forcodedancing forcodedancing commented Oct 27, 2022 •
edited
Loading

Description

Two fixes and refactor in this pr:

  1. fix witness data when gas account sending txs
  2. fix gas calculation issue in committer
  3. various refactor: rename function names, remove unneeded logs, sort imports

Rationale

Bug fix

Example

NA

Changes

Notable changes:

  • bug fix

@forcodedancing forcodedancing added ready for review ready for review bug Something isn't working enhancement New feature or request labels Oct 27, 2022
@forcodedancing forcodedancing mentioned this pull request Oct 28, 2022
Merged
keefel
keefel approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@keefel keefel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lightning-li
lightning-li approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@lightning-li lightning-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forcodedancing forcodedancing merged commit 4cff0b5 into bnb-chain:develop Oct 28, 2022
@forcodedancing forcodedancing changed the title fix: correct witness data when gas account sending txs fix: correct witness and committer when gas account sending txs Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightning-li lightning-li lightning-li approved these changes

@keefel keefel keefel approved these changes

@NashBC NashBC NashBC approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request ready for review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@forcodedancing @lightning-li @keefel @NashBC