Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support query account tx APIs by txType #227

Merged
merged 5 commits into from
Oct 20, 2022
Merged

feat: support query account tx APIs by txType #227

merged 5 commits into from
Oct 20, 2022

Conversation

carlcarl
Copy link
Contributor

@carlcarl carlcarl commented Oct 18, 2022 •
edited
Loading

Description

Use function arguments to support query account txs by tx type

Rationale

zkwallet frontend need the API changes

Example

Add type[] in query string and it's optional

GET /api/v1/accountTxs?by=account_index&value=1&offset=0&limit=10&types=[7,8]

Array usage ref: zeromicro/go-zero#2334 (comment)

Changes

N/A

@carlcarl carlcarl added work in progress work in progress ready for review ready for review and removed work in progress work in progress labels Oct 18, 2022
@carlcarl carlcarl marked this pull request as ready for review October 18, 2022 08:14
@carlcarl carlcarl added work in progress work in progress and removed ready for review ready for review labels Oct 20, 2022
@carlcarl carlcarl marked this pull request as draft October 20, 2022 04:23
@carlcarl carlcarl added ready for review ready for review and removed work in progress work in progress labels Oct 20, 2022
@carlcarl carlcarl marked this pull request as ready for review October 20, 2022 06:00
@carlcarl carlcarl merged commit a8b19cf into develop Oct 20, 2022
@forcodedancing forcodedancing mentioned this pull request Oct 28, 2022
Merged
@carlcarl carlcarl deleted the feat/query-account-txs-by-type branch November 11, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

Assignees
No one assigned
Labels
ready for review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlcarl @forcodedancing @carl-h-20230331