Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export toAccountIndex and toAccountName in Tx APIs #226

Merged
merged 2 commits into from
Oct 18, 2022
Merged

feat: export toAccountIndex and toAccountName in Tx APIs #226

merged 2 commits into from
Oct 18, 2022

Conversation

carlcarl
Copy link
Contributor

Description

Export to_account_index and to_account_name in Tx APIs.
The two fields are meaningful only when the tx type is transfer/transferNft/MintNft.

Rationale

zkWallet frontend need the fields in tx

Example

GET /api/v1/tx?hash=xxx

Response:

{
  "hash": ...,
  "type": 7 // mint NFT
  ......
  "to_account_index": 2, // new field
  "to_account_name": "test.lengend" // new field
}

Changes

N/A

@carlcarl carlcarl marked this pull request as ready for review October 18, 2022 07:50
@carlcarl carlcarl added the ready for review ready for review label Oct 18, 2022
@carlcarl carlcarl merged commit 781774b into develop Oct 18, 2022
@forcodedancing forcodedancing mentioned this pull request Oct 28, 2022
Merged
@carlcarl carlcarl deleted the feat/export-to-account-index-and-name branch November 11, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

Assignees
No one assigned
Labels
ready for review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlcarl @forcodedancing @carl-h-20230331