feat: add totalAssetValue in GetAccount API response #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +77,9 @@ func (l *GetAccountLogic) GetAccount(req *types.ReqGetAccount) (resp *types.Acco | |||
| Nonce: account.Nonce, | |||
| Assets: make([]*types.AccountAsset, 0, len(account.AssetInfo)), | |||
| } | |||
|
|
|||
| totalAssetPrice := big.NewFloat(0) | |||
There was a problem hiding this comment.
price seems to be not a good name. How about totalAssetAmount or totalAssetValue? Can you refer to some dapp (e.g., pancake, uniswap) for the name
There was a problem hiding this comment.
totalAssetValue seems better
| // 1. Convert unit of balance from wei to BNB | ||
| // 2. Calculate the result of (BNB balance * price per BNB) | ||
| balanceInFloat := new(big.Float).SetInt(asset.Balance) | ||
| unitConversion := new(big.Int).Exp(big.NewInt(10), big.NewInt(18), nil) |
There was a problem hiding this comment.
Different assets have different units. Decimal field of asset is for this, i believe.
forcodedancing
requested changes
Oct 10, 2022
docs/api_reference.md
Outdated
| | pk | string | | Yes | | ||
| | nonce | long | | Yes | | ||
| | assets | [ [AccountAsset](#accountasset) ] | | Yes | | ||
| | total_asset_price | string | | Yes | |
There was a problem hiding this comment.
Need to change the doc
carlcarl
changed the title
carlcarl
changed the title
unclezoro
approved these changes
Oct 11, 2022
forcodedancing
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add totalAssetValue in GetAccount API response.
Rationale
Account page need show the value
Example
N/A
Changes
N/A
/update-integration-keyfile