Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pevm: If TxDAG is nil, then use the serial processor to handle it. #203

Merged

Conversation

welkin22
Copy link
Contributor

Description

If TxDAG is nil, then use the serial processor to handle it.

Rationale

The current version of TxDAG reads from a file, so it may not be able to read after a certain block height, and a serial processor should be used to execute it.

Copy link
Collaborator

@sunny2022da sunny2022da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
maybe in future we can have a separate flag such as "parallel.trustDAG", so that parallel merge and other features could reuse it .
But let's keep the minimal change at present.

@welkin22 welkin22 merged commit c5f1c9e into bnb-chain:feature/TxDAG-PEVM Oct 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants