fix: Fix pbss snapshot inconsistency with engine-sync enabled when starting #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish-nr
force-pushed
the
fix_pbss_snapshot
branch
from
51a4d71
to
581ea90
Compare
nolanxyg
approved these changes
Sep 27, 2024
bnoieh
previously approved these changes
Sep 27, 2024
krish-nr
force-pushed
the
fix_pbss_snapshot
branch
from
581ea90
to
655e8f8
Compare
welkin22
reviewed
Sep 27, 2024
bnoieh
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue arises when PBSS snapshots are created without stopping the system, leading to inconsistencies in safe and unsafe block heights due to data persistence order. This problem occurs specifically when engine-sync is enabled, preventing proper recovery.
Rationale
This fix addresses an issue with starting snapshots created using PBSS in specific scenarios. PBSS snapshots generated without stopping can result in inconsistencies in the safe and unsafe block heights due to the order of data persistence. In cases where engine-sync is not enabled, the existing logic can automatically recover and start. However, when engine-sync is enabled, the initialization logic prevents entry into the op-node's recovery logic. Therefore, this fix adjusts the block height relationships during Geth initialization to resolve the issue.
Example
N/A