optimization: txpool pricedlist only reheap when pool is full #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for v0.5.0 release
bnoieh
approved these changes
Oct 8, 2024
owen-reorg
approved these changes
Oct 10, 2024
owen-reorg
changed the title
owen-reorg
added a commit
that referenced
this pull request
Oct 14, 2024
Co-authored-by: Owen <103096885+owen-reorg@users.noreply.github.com> Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
This was referenced Oct 14, 2024
welkin22
added a commit
to welkin22/op-geth
that referenced
this pull request
Oct 28, 2024
…bnb-chain#175)" This reverts commit c1420cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pricedlist
LegacyTxpool.pricedis used to evict transactions when the pool overflows. It sorts all remote pending transactions by nonce and price and decides which transaction to stay and which to remove. It only works when the pool is full, but re-heap every second when the state of the pool changes.. The cost of re-heap is hight because it re-sorts all the pending transactions.This improvement changes it to "only re-heap when the pool overflows", so that:
LegacyTxpool.runReorg()cost less time to update the whole state of the pool.LegacyTxpool.Add()can be called more because it shares the mu.Lock withLegacyTxpool.runReorg()LegacyTxpool.Add()does.All of these will support higher TPS on the pool.