-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recover node buffer list for pathdb #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
force-pushed
the
feat-difflayertool
branch
7 times, most recently
from
July 10, 2024 04:08
2123434
to
3ad50e4
Compare
will-2012
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, this new difflayer redolog rebuild skeleton is ok.
sysvm
force-pushed
the
feat-difflayertool
branch
20 times, most recently
from
July 11, 2024 03:59
f824707
to
443e221
Compare
welkin22
reviewed
Jul 29, 2024
welkin22
reviewed
Jul 29, 2024
sysvm
force-pushed
the
feat-difflayertool
branch
2 times, most recently
from
August 13, 2024 02:53
06fdd4c
to
07f40d4
Compare
sysvm
force-pushed
the
feat-difflayertool
branch
from
August 28, 2024 03:29
07f40d4
to
ea2c9d4
Compare
sysvm
force-pushed
the
feat-difflayertool
branch
13 times, most recently
from
September 9, 2024 07:06
179579b
to
7d7eaa1
Compare
sysvm
force-pushed
the
feat-difflayertool
branch
from
September 10, 2024 03:56
94a0c19
to
8e3263f
Compare
sysvm
force-pushed
the
feat-difflayertool
branch
from
September 20, 2024 02:37
e7454bc
to
3bf57a4
Compare
krish-nr
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jingjunLi
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recover node buffer list for pathdb to avoid dropping many blocks in node buffer list. If using nodebufferlist and op-geth is force kill, it will recover nodebufferlist by default.
Rationale
The sequencer module of opBNB is used to generate blocks. At present, opBNB blocks out of a single node. If the force kill or OOM is performed on the sequencer module, a large number of blocks will be left, and the data stored in the nodecache will be lost. Therefore, this pr can be used to recover data on nodebufferlist.
Example
N/A
Changes
Notable changes: