feat: add "X-Gnfd-Expires" header #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jul 24, 2023
unclezoro
reviewed
Jul 24, 2023
ruojunm
force-pushed
the
feat-addExpiryHeader
branch
from
c70f479
to
b7d0583
Compare
flywukong
reviewed
Jul 24, 2023
|
|
||
| // GetMsgToSignForPreSignedURL is only used in SP get Object API. This util method can be used in by SP side and client side to construct the MsgToSign | ||
| func GetMsgToSignForPreSignedURL(req *http.Request) []byte { | ||
| queryValues := req.URL.Query() |
There was a problem hiding this comment.
if len(queryValues) == 0 {
return nil
}
unclezoro
reviewed
Jul 24, 2023
| // HTTPHeaderExpiryTimestamp defines the expiry timestamp, which is the ISO 8601 datetime string (e.g. 2021-09-30T16:25:24Z), and the maximum Timestamp since the request sent must be less than MaxExpiryAgeInSec (seven days). | ||
| HTTPHeaderExpiryTimestamp = "X-Gnfd-Expiry-Timestamp" | ||
| // MaxExpiryAgeInSec | ||
| MaxExpiryAgeInSec = 3600 * 24 * 7 // 7 days |
There was a problem hiding this comment.
MaxExpiryAgeInSec seems not proper to define here. It is application level param, not suitable on a common lib.
unclezoro
approved these changes
Jul 24, 2023
ruojunm
added a commit
that referenced
this pull request
Aug 30, 2023
* feat: add "X-Gnfd-Expires" header (#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add "X-Gnfd-Expires" header and simplify GetMsgToSign
Rationale
Changes
Notable changes: