feat: support parallel hash computing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flywukong
force-pushed
the
feat-parallel-hash
branch
from
df3dd24
to
6ec64a8
Compare
flywukong
changed the title
flywukong
force-pushed
the
feat-parallel-hash
branch
from
52470b6
to
5aa27c4
Compare
flywukong
force-pushed
the
feat-parallel-hash
branch
from
5aa27c4
to
368d179
Compare
jingjunLi
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support parallel hash computing before creating object in the client .
The function will utilize multiple threads based on the number of CPU cores of the user's operating system. Considering that the client's computing capability may be limited, the function currently limits the maximum concurrent threads to 5.
test result (mac OS with 6 cpu core ):
file size less than 16M:
serial computing hash cost time: 92 ms
parallel computing hash cost time: 88 ms
file size 100M:
serial computing hash cost time: 710 ms
parallel computing hash cost time: 211 ms
file size 500M:
serial computing hash cost time: 3439 ms
parallel computing hash cost time: 898 ms
file size 1G:
serial computing hash cost time: 12378 ms
parallel computing hash cost time: 2378 ms
Rationale
support computing hash of larger file by a parallel way
Example
NA
Changes
Notable changes: