Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate get diff accounts with scope #493

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

keefel
Copy link
Contributor

@keefel keefel commented Oct 29, 2021

Description

Add needToReplay condition to accelerate eth_getDiffAccountsWithScope

Rationale

Replay the whole block spend too much time, actually we need't do that, so add an quick way to decide whether to replay the block.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@keefel keefel force-pushed the accelarate branch 4 times, most recently from 7ffc65d to d540c1c Compare November 3, 2021 03:52
Transactions: make([]types.DiffAccountsInTx, 0),
}

if needReplay, err := s.needToReplay(ctx, block, accounts); !needReplay {
Copy link
Contributor

@yutianwu yutianwu Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we test err first if needReplay, err := s.needToReplay(ctx, block, accounts); err != nil {

Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
@unclezoro unclezoro merged commit 94e5e6c into bnb-chain:develop Nov 8, 2021
@keefel keefel deleted the accelarate branch January 7, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants