BEP648: fix race condition in early finalization.#3547
Merged
allformless merged 1 commit intobnb-chain:developfrom Feb 4, 2026
Merged
BEP648: fix race condition in early finalization.#3547allformless merged 1 commit intobnb-chain:developfrom
allformless merged 1 commit intobnb-chain:developfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
ede98fb to
3247efe
Compare
NathanBSC
approved these changes
Feb 4, 2026
allformless
approved these changes
Feb 4, 2026
galaio
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's a fix for #3520
Fix a critical race condition in CheckFinalityAndNotify where the function relied on currentHeader matching targetBlockHash. Since currentHeader is updated later than highestVerifiedBlock in writeBlockAndSetHead, votes entering curVotes (via GetVerifiedBlockByHash check) would trigger CheckFinalityAndNotify before currentHeader was updated, causing the check to fail.
Rationale
In writeBlockAndSetHead, highestVerifiedBlock is set before currentHeader. When votes arrive and GetVerifiedBlockByHash returns non-nil, they enter curVotes and trigger CheckFinalityAndNotify. However, currentHeader hasn't been updated yet, so the check
currentHeader.Hash() != targetBlockHashfails, preventing early finalization from working correctly.Example
Before fix:
After fix:
Changes
Notable changes:
checking currentHeader.Hash() == targetBlockHash
already-finalized blocks