eip4844: disable eip-7918 for bsc#3531
Merged
buddh0 merged 1 commit intobnb-chain:developfrom Jan 27, 2026
Merged
Conversation
buddh0
reviewed
Jan 27, 2026
| // CalcExcessBlobGas calculates the excess blob gas after applying the set of | ||
| // blobs on top of the excess blob gas. | ||
| func CalcExcessBlobGas(config *params.ChainConfig, parent *types.Header, headTimestamp uint64) uint64 { | ||
| isOsaka := config.IsOsaka(config.LondonBlock, headTimestamp) |
Contributor
There was a problem hiding this comment.
isOsaka --> eip7918 ?
and
func calcExcessBlobGas(isOsaka bool, bcfg *BlobConfig, parent *types.Header) uint64 {
-->
func calcExcessBlobGas(eip7918 bool, bcfg *BlobConfig, parent *types.Header) uint64 {
zlacfzy
force-pushed
the
disable_eip_7918
branch
from
85acb01 to
c7caa47
Compare
buddh0
approved these changes
Jan 27, 2026
flywukong
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable EIP-7918 for BSC because BSC's base fee is zero.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: