performance: commitTire concurrently during Commit #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilliant-lx
changed the title
brilliant-lx
requested review from
buddh0,
joeylichang,
galaio,
fynnss and
RenRick
buddh0
approved these changes
Oct 26, 2023
galaio
approved these changes
Oct 26, 2023
|
run full sync for 2 days, it is ok, so merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
StateDB::Commit(), runcommmitTrie()concurrently to improve the performance.Previous commitTrie was changed to be run serially for
--pipecommit, but actually, it is ok to run it concurrently.Rationale
It was broken after v1.3.0 due to a object concurrent access safety, to reenable it
Implementation
the safety was about:
StateDB.storagesit is used to store the modified KV pair for each address on updateTrie which is called during block validation phase, the key is with Keccak hashed.