parlia: reject header with WithdrawalsHash before shanghai fork
#1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
reject_WithdrawalsHash_before_shanghai
branch
from
8537d4e to
ba32957
Compare
NathanBSC
changed the title
WithdrawalsHash before shanghaiWithdrawalsHash before shanghai fork
NathanBSC
force-pushed
the
reject_WithdrawalsHash_before_shanghai
branch
from
969ef72 to
95d19ed
Compare
brilliant-lx
previously approved these changes
Sep 21, 2023
brilliant-lx
approved these changes
Sep 21, 2023
galaio
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
consensus/parlia: reject header with WithdrawalsHash before shanghai fork
Rationale
WithdrawalsHash is not need by bsc, ensure it to be nil
Example
add an example CLI or API response...
Changes
Notable changes:
miner.delayleftoverin help doc and shadow flagminer.newpayload-timeout,disable warn log about
newpayloadTimeout, because it's useless for bscchainconfigfor VotePool and VoteManagerkeep consistent with go-ethereum, miss them when big merge:
LoadChainConfigto replaceSetupGenesisBlockWithOverride, the later func has been called inNewBlockChainSynchronisetoLegacySync