This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
... #73
Closed
... #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously type-checks were done by doing type(obj) is klass This doesn't take into account 'future' libs that use object inheritance to backport new features from 3 to 2 without breaking 2-only libs. Now type-checks are done using 'isinstance', which is a more relaxed type-check, but also the desired behavior typically.
This works as expected when an id is not provided to DBObject.find(where=...), but failed to work when using specifying an id DBObject.find(id, where=...). InteractionBase.select() discards the clause if an id is provided. This patch retains any provided where clause.
|
Thanks for this! I think the only thing that I'm not sure should be changed is updating each class to extend |
|
Sorry this was not meant to be a PR. I actually just wanted to merge back the most recent commits into my fork, but somehow i failed. However you might be interessted in my most recent commit (sehoffmann@06151f9) which adds real transactions (...which don't block the freaking main thread). In the next days i will add SAVEPOINT support so you might want to wait before opening a PR. PS: Please don't drop Python2 support or is there any important reason? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.